Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync UI from VertexAI for Firebase #172

Merged
merged 2 commits into from
May 16, 2024
Merged

Sync UI from VertexAI for Firebase #172

merged 2 commits into from
May 16, 2024

Conversation

1998code
Copy link
Contributor

Description of the change

Follow-up from firebase/firebase-ios-sdk#12887

Motivation

Sync the updated User Interface from VertexAI repo.

Type of change

Choose one: Other

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels May 16, 2024
@1998code 1998code mentioned this pull request May 16, 2024
Merged
@1998code
Copy link
Contributor Author

Style fixed 🙈🙏

@andrewheard andrewheard self-requested a review May 16, 2024 14:48
@andrewheard
Copy link
Collaborator

Style fixed 🙈🙏

I used to forget to do this all the time. Thanks for re-running!

andrewheard
andrewheard approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions, @1998code!

@andrewheard andrewheard merged commit e8bbb72 into google-gemini:main May 16, 2024
8 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees

@andrewheard andrewheard

Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1998code @andrewheard