Skip to content

Commit

Permalink
Fix transformer, effect, muxer and container API dependencies
Browse files Browse the repository at this point in the history
The public APIs of these modules reference symbols in some of their
dependencies, so these should be API dependencies, not implementation:
> An API dependency is one that contains at least one type that is
> exposed in the library binary interface, often referred to as its ABI
> (Application Binary Interface).

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_recognizing_dependencies

Transformer also uses symbols from `lib-common`, but these are already
an API dep of `lib-exoplayer` so no need to duplicate that here.

PiperOrigin-RevId: 605660621
  • Loading branch information
icbaker authored and Copybara-Service committed Feb 9, 2024
1 parent 53cbcbc commit 653cc9c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion library/container/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ android {
}

dependencies {
implementation project(modulePrefix + 'library-common')
api project(modulePrefix + 'library-common')
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
testImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
testImplementation 'com.google.truth:truth:' + truthVersion
Expand Down
2 changes: 1 addition & 1 deletion library/effect/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ android {

dependencies {
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
implementation project(modulePrefix + 'library-common')
api project(modulePrefix + 'library-common')
implementation project(modulePrefix + 'library-datasource')
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
Expand Down
2 changes: 1 addition & 1 deletion library/muxer/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ android {
}

dependencies {
implementation project(modulePrefix + 'library-common')
api project(modulePrefix + 'library-common')
implementation project(modulePrefix + 'library-container')
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
Expand Down
4 changes: 2 additions & 2 deletions library/transformer/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ dependencies {
implementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
implementation project(modulePrefix + 'library-datasource')
implementation project(modulePrefix + 'library-container')
implementation project(modulePrefix + 'library-core')
implementation project(modulePrefix + 'library-effect')
api project(modulePrefix + 'library-core')
api project(modulePrefix + 'library-effect')
implementation project(modulePrefix + 'library-muxer')
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
Expand Down

0 comments on commit 653cc9c

Please sign in to comment.