Merge pull request #10995 from google/release-v2-r2.18.3

r2.18.3

.github/ISSUE_TEMPLATE/bug.yml

@@ -18,6 +18,7 @@ body:
       label: ExoPlayer Version
       description: What version of ExoPlayer are you using?
       options:
+        - 2.18.3
         - 2.18.2
         - 2.18.1
         - 2.18.0

RELEASENOTES.md

@@ -1,5 +1,79 @@
 # Release notes
 
+### 2.18.3 (2023-02-16)
+
+This release corresponds to the
+[AndroidX Media3 1.0.0-rc01 release](https://github.com/androidx/media/releases/tag/1.0.0-rc01).
+
+*   Core library:
+    *   Tweak the renderer's decoder ordering logic to uphold the
+        `MediaCodecSelector`'s preferences, even if a decoder reports it may not
+        be able to play the media performantly. For example with default
+        selector, hardware decoder with only functional support will be
+        preferred over software decoder that fully supports the format
+        ([#10604](https://github.com/google/ExoPlayer/issues/10604)).
+    *   Add `ExoPlayer.Builder.setPlaybackLooper` that sets a pre-existing
+        playback thread for a new ExoPlayer instance.
+    *   Allow download manager helpers to be cleared
+        ([#10776](https://github.com/google/ExoPlayer/issues/10776)).
+    *   Add parameter to `BasePlayer.seekTo` to also indicate the command used
+        for seeking.
+    *   Use theme when loading drawables on API 21+
+        ([#220](https://github.com/androidx/media/issues/220)).
+    *   Add `ConcatenatingMediaSource2` that allows combining multiple media
+        items into a single window
+        ([#247](https://github.com/androidx/media/issues/247)).
+*   Extractors:
+    *   Throw a `ParserException` instead of a `NullPointerException` if the
+        sample table (stbl) is missing a required sample description (stsd) when
+        parsing trak atoms.
+    *   Correctly skip samples when seeking directly to a sync frame in fMP4
+        ([#10941](https://github.com/google/ExoPlayer/issues/10941)).
+*   Audio:
+    *   Use the compressed audio format bitrate to calculate the min buffer size
+        for `AudioTrack` in direct playbacks (passthrough).
+*   Text:
+    *   Fix `TextRenderer` passing an invalid (negative) index to
+        `Subtitle.getEventTime` if a subtitle file contains no cues.
+    *   SubRip: Add support for UTF-16 files if they start with a byte order
+        mark.
+*   Metadata:
+    *   Parse multiple null-separated values from ID3 frames, as permitted by
+        ID3 v2.4.
+    *   Add `MediaMetadata.mediaType` to denote the type of content or the type
+        of folder described by the metadata.
+    *   Add `MediaMetadata.isBrowsable` as a replacement for
+        `MediaMetadata.folderType`. The folder type will be deprecated in the
+        next release.
+*   DASH:
+    *   Add full parsing for image adaptation sets, including tile counts
+        ([#3752](https://github.com/google/ExoPlayer/issues/3752)).
+*   UI:
+    *   Fix the deprecated
+        `StyledPlayerView.setControllerVisibilityListener(StyledPlayerControlView.VisibilityListener)`
+        to ensure visibility changes are passed to the registered listener
+        ([#229](https://github.com/androidx/media/issues/229)).
+    *   Fix the ordering of the center player controls in `StyledPlayerView`
+        when using a right-to-left (RTL) layout
+        ([#227](https://github.com/androidx/media/issues/227)).
+*   Cast extension:
+    *   Bump Cast SDK version to 21.2.0.
+*   IMA extension:
+    *   Remove player listener of the `ImaServerSideAdInsertionMediaSource` on
+        the application thread to avoid threading issues.
+    *   Add a property `focusSkipButtonWhenAvailable` to the
+        `ImaServerSideAdInsertionMediaSource.AdsLoader.Builder` to request
+        focusing the skip button on TV devices and set it to true by default.
+    *   Add a method `focusSkipButton()` to the
+        `ImaServerSideAdInsertionMediaSource.AdsLoader` to programmatically
+        request to focus the skip button.
+    *   Fix a bug which prevented playback from starting for a DAI stream
+        without any ads.
+    *   Bump IMA SDK version to 3.29.0.
+*   Demo app:
+    *   Request notification permission for download notifications at runtime
+        ([#10884](https://github.com/google/ExoPlayer/issues/10884)).
+
 ### 2.18.2 (2022-11-22)
 
 This release corresponds to the

constants.gradle

@@ -13,8 +13,8 @@
 // limitations under the License.
 project.ext {
     // ExoPlayer version and version code.
-    releaseVersion = '2.18.2'
-    releaseVersionCode = 2_018_002
+    releaseVersion = '2.18.3'
+    releaseVersionCode = 2_018_003
     minSdkVersion = 16
     appTargetSdkVersion = 33
     // API version before restricting local file access.

demos/main/src/main/AndroidManifest.xml

@@ -23,6 +23,7 @@
   <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
   <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
   <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
+  <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
 
   <uses-feature android:name="android.software.leanback" android:required="false"/>
   <uses-feature android:name="android.hardware.touchscreen" android:required="false"/>
@@ -35,6 +36,7 @@
       android:largeHeap="true"
       android:allowBackup="false"
       android:requestLegacyExternalStorage="true"
+      android:supportsRtl="true"
       android:name="androidx.multidex.MultiDexApplication"
       tools:targetApi="29">
 

demos/main/src/main/java/com/google/android/exoplayer2/demo/SampleChooserActivity.java

@@ -19,6 +19,7 @@
 import static com.google.common.base.Preconditions.checkNotNull;
 import static com.google.common.base.Preconditions.checkState;
 
+import android.Manifest;
 import android.content.Context;
 import android.content.Intent;
 import android.content.SharedPreferences;
@@ -41,7 +42,9 @@
 import android.widget.ImageButton;
 import android.widget.TextView;
 import android.widget.Toast;
+import androidx.annotation.DoNotInline;
 import androidx.annotation.Nullable;
+import androidx.annotation.RequiresApi;
 import androidx.appcompat.app.AppCompatActivity;
 import com.google.android.exoplayer2.MediaItem;
 import com.google.android.exoplayer2.MediaItem.ClippingConfiguration;
@@ -75,13 +78,16 @@ public class SampleChooserActivity extends AppCompatActivity
   private static final String TAG = "SampleChooserActivity";
   private static final String GROUP_POSITION_PREFERENCE_KEY = "sample_chooser_group_position";
   private static final String CHILD_POSITION_PREFERENCE_KEY = "sample_chooser_child_position";
+  private static final int POST_NOTIFICATION_PERMISSION_REQUEST_CODE = 100;
 
   private String[] uris;
   private boolean useExtensionRenderers;
   private DownloadTracker downloadTracker;
   private SampleAdapter sampleAdapter;
   private MenuItem preferExtensionDecodersMenuItem;
   private ExpandableListView sampleListView;
+  @Nullable private MediaItem downloadMediaItemWaitingForNotificationPermission;
+  private boolean notificationPermissionToastShown;
 
   @Override
   public void onCreate(Bundle savedInstanceState) {
@@ -170,12 +176,34 @@ public void onDownloadsChanged() {
   public void onRequestPermissionsResult(
       int requestCode, String[] permissions, int[] grantResults) {
     super.onRequestPermissionsResult(requestCode, permissions, grantResults);
+    if (requestCode == POST_NOTIFICATION_PERMISSION_REQUEST_CODE) {
+      handlePostNotificationPermissionGrantResults(grantResults);
+    } else {
+      handleExternalStoragePermissionGrantResults(grantResults);
+    }
+  }
+
+  private void handlePostNotificationPermissionGrantResults(int[] grantResults) {
+    if (!notificationPermissionToastShown
+        && (grantResults.length == 0 || grantResults[0] != PackageManager.PERMISSION_GRANTED)) {
+      Toast.makeText(
+              getApplicationContext(), R.string.post_notification_not_granted, Toast.LENGTH_LONG)
+          .show();
+      notificationPermissionToastShown = true;
+    }
+    if (downloadMediaItemWaitingForNotificationPermission != null) {
+      // Download with or without permission to post notifications.
+      toggleDownload(downloadMediaItemWaitingForNotificationPermission);
+      downloadMediaItemWaitingForNotificationPermission = null;
+    }
+  }
+
+  private void handleExternalStoragePermissionGrantResults(int[] grantResults) {
     if (grantResults.length == 0) {
       // Empty results are triggered if a permission is requested while another request was already
       // pending and can be safely ignored in this case.
       return;
-    }
-    if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
+    } else if (grantResults[0] == PackageManager.PERMISSION_GRANTED) {
       loadSample();
     } else {
       Toast.makeText(getApplicationContext(), R.string.sample_list_load_error, Toast.LENGTH_LONG)
@@ -242,15 +270,26 @@ private void onSampleDownloadButtonClicked(PlaylistHolder playlistHolder) {
     if (downloadUnsupportedStringId != 0) {
       Toast.makeText(getApplicationContext(), downloadUnsupportedStringId, Toast.LENGTH_LONG)
           .show();
+    } else if (!notificationPermissionToastShown
+        && Util.SDK_INT >= 33
+        && checkSelfPermission(Api33.getPostNotificationPermissionString())
+            != PackageManager.PERMISSION_GRANTED) {
+      downloadMediaItemWaitingForNotificationPermission = playlistHolder.mediaItems.get(0);
+      requestPermissions(
+          new String[] {Api33.getPostNotificationPermissionString()},
+          /* requestCode= */ POST_NOTIFICATION_PERMISSION_REQUEST_CODE);
     } else {
-      RenderersFactory renderersFactory =
-          DemoUtil.buildRenderersFactory(
-              /* context= */ this, isNonNullAndChecked(preferExtensionDecodersMenuItem));
-      downloadTracker.toggleDownload(
-          getSupportFragmentManager(), playlistHolder.mediaItems.get(0), renderersFactory);
+      toggleDownload(playlistHolder.mediaItems.get(0));
     }
   }
 
+  private void toggleDownload(MediaItem mediaItem) {
+    RenderersFactory renderersFactory =
+        DemoUtil.buildRenderersFactory(
+            /* context= */ this, isNonNullAndChecked(preferExtensionDecodersMenuItem));
+    downloadTracker.toggleDownload(getSupportFragmentManager(), mediaItem, renderersFactory);
+  }
+
   private int getDownloadUnsupportedStringId(PlaylistHolder playlistHolder) {
     if (playlistHolder.mediaItems.size() > 1) {
       return R.string.download_playlist_unsupported;
@@ -627,4 +666,13 @@ public PlaylistGroup(String title) {
       this.playlists = new ArrayList<>();
     }
   }
+
+  @RequiresApi(33)
+  private static class Api33 {
+
+    @DoNotInline
+    public static String getPostNotificationPermissionString() {
+      return Manifest.permission.POST_NOTIFICATIONS;
+    }
+  }
 }

demos/main/src/main/res/values/strings.xml

@@ -45,6 +45,8 @@
 
   <string name="sample_list_load_error">One or more sample lists failed to load</string>
 
+  <string name="post_notification_not_granted">Notifications suppressed. Grant permission to see download notifications.</string>
+
   <string name="download_start_error">Failed to start download</string>
 
   <string name="download_start_error_offline_license">Failed to obtain offline license</string>

docs/_includes/media3-known-issue-box.html

@@ -0,0 +1,2 @@
+**[Known issue #{{include.issue-id}}](https://github.com/androidx/media/issues/{{include.issue-id}})** - {{ include.description }}
+{:.error}