Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Update Dokka to 1.8.10, Fix search #1595

Merged
merged 2 commits into from Apr 29, 2023
Merged

[Documentation] Update Dokka to 1.8.10, Fix search #1595

merged 2 commits into from Apr 29, 2023

Conversation

illarionov
Copy link
Contributor

Update Dokka to 1.8.10

This fixes the NoSuchMethodError exception when running the dokkaHtmlMultiModule task that appeared after upgrading Gradle to 8.1 (Kotlin/dokka#2796).
This also brings a new UI for the API documentation pages.

Fixed search on documentation page

Turned on alternate style on the Tabbed extension of the mkdocs-material to fix search on internal doc pages (fixes #1533).
Also locked the major version of the mkdocs-material to prevent uncontrolled updates in the future and added the gradle/gradle-build-action@v2 action to the publishing documentation workflow as in other workflows

* Turn on alternative style for the Tabbed extension
* Lock the major version of the mkdocs-material in the documentation publishing workflow
* Use gradle/gradle-build-action@v2 in the documentation publishing as in other workflows
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This looks like a great improvement

@bentrengrove bentrengrove merged commit 724ee6c into google:main Apr 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is broken on some pages of the documentation
2 participants