An attempt to establish go mods throughout AGI and changing namespace… #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (gapid => agi) Note: go mod only indexes packages which have at least a go file declared. As such there is a need to add dummy.go files in .proto services. Although it might appear hacky, this is actually standard practice across many go repos. When go mod changes we'll need to run: `bazel run //:gazelle -- update-repos -from_file=go.mod` Not sure if there's a hook or a way to trigger bazel to do that on build?
GOOG-sergiu
commented
Oct 12, 2022
| @@ -123,7 +123,7 @@ function run_enumerate_lints() { | |||
|
|
|||
| function run_gazelle() { | |||
| echo # TODO: figure out a way to make bazel not print anything. | |||
| $BAZEL run gazelle | |||
| $BAZEL run gazelle -- update-repos -from_file=go.mod | |||
There was a problem hiding this comment.
Modified the presubmit to read from go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (gapid => agi)
Note: go mod only indexes packages which have at least a go file declared. As such there is a need to add dummy.go files in .proto services. Although it might appear hacky, this is actually standard practice across many go repos.
When go mod changes we'll need to run:
bazel run //:gazelle -- update-repos -from_file=go.modUPDATE: ^ doing this in presubmit.sh solves this issue. Let me know if there are any concerns with this.
Not sure if there's a hook or a way to trigger bazel to do that on build?