Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO 8601 duration serializer supporting microseconds #1232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solwey-wes
Copy link

@solwey-wes solwey-wes commented Apr 18, 2023

Added a new serializer with support for sub-second durations in ISO 8601 strings. Eg: "PT9.977S". I think this regex is solid and backwards compatible but worth a double-check...my regex game was pretty weak at the start of this task and GPT4 wasn't very helpful :P

I didn't try to add support for the longer units of time (weeks/months/years) since they weren't relevant to my use case.

@google-cla
Copy link

google-cla bot commented Apr 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@davidmorgan
Copy link
Collaborator

Thanks.

I think we would only merge this if there is sufficient interest, i.e. if others are asking for it too. Otherwise it's simpler if you keep it as a local change. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants