Fix some low hanging fruit from issues/1191 #1192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkdn maintains these rules internally and would need to do this merge, assuming it's feasible. |
|
@shicks I cannot add labels to PRs in the repo. Could you add label |
|
When did sis have the time to become whiz of axe?!
Regards,
Miss Bash
…________________________________
From: Goktug Gokdogan ***@***.***>
Sent: Thursday, April 13, 2023 8:01 PM
To: google/closure-library ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [google/closure-library] Fix some low hanging fruit from issues/1191 (PR #1192)
@shicks<https://github.com/shicks> I cannot add labels to PRs in the repo. Could you add label Reviewing Internally?
—
Reply to this email directly, view it on GitHub<#1192 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVYQQ36ZNKHLZLKQ27KFYQTXBCHU3ANCNFSM6AAAAAAWXZ2EMM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1191
strip_prefixfor@io_bazel_rules_closureto allow build to progress further.lenient=1from rules that don't allow it.testonly=Trueon a rule that requires it.