Skip to content

Commit

Permalink
Update Dagger's GitHub Actions to move the remaining emulator test to…
Browse files Browse the repository at this point in the history
… run in post-submit only.

The emulator tests have become more flaky recently and are also one of our slowest jobs in GitHub Actions. It should be fairly safe to move these to post-submit given our other non-emulator test coverage.

This CL also updates the release script to use the large-runner. This should be negligible to the overall cost since releases are done so infrequently compared to presubmits.

RELNOTES=N/A
PiperOrigin-RevId: 587014286
  • Loading branch information
bcorso authored and Dagger Team committed Dec 1, 2023
1 parent b074037 commit a6e65fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,6 @@ jobs:
with:
agp: '${{ matrix.agp }}'
jdk: '${{ matrix.jdk }}'
artifact-android-emulator-tests:
name: 'Artifact Android emulator tests (API 30)'
needs: bazel-build
# It's recommended to run emulator tests on macOS
# See https://github.com/marketplace/actions/android-emulator-runner
runs-on: macos-latest
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/artifact-android-emulator-tests
timeout-minutes: 35 # TODO(b/287486065) investigate whether there is performance regression
with:
api-level: '30'
artifact-android-emulator-legacy-api-tests:
name: 'Artifact Android emulator tests (API ${{ matrix.api-level }})'
# We only run this on master push (essentially a postsubmit) since these
Expand All @@ -99,7 +87,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix: # Run on 16 (PreL), 21 (L), and 26 (O).
api-level: [16, 21, 26]
api-level: [16, 21, 26, 30]
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/artifact-android-emulator-tests
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ jobs:
bazel-test:
name: 'Bazel tests'
needs: validate-latest-dagger-version
runs-on: ubuntu-latest
runs-on:
group: large-runner
labels: ubuntu-22.04-16core
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/bazel-test
Expand Down

0 comments on commit a6e65fa

Please sign in to comment.