Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript (.ts) port of the file diff_match_patch_uncompressed.js #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ramin-zaghi
Copy link

This is useful for projects that use Typescript (e.g. a Visual Studio Code Extension).
Tested using the same logic as is present in the Patch Demo.
"visualSilicon" has also submitted a CLA for contributions to Google open-source projects.

@google-cla
Copy link

google-cla bot commented Sep 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ramin-zaghi
Copy link
Author

@NeilFraser would you review and merge this please? or do you no longer accept changes to this project?

@Azmisov
Copy link

Azmisov commented Dec 17, 2022

All JavaScript is Typescript, but not the other way around. Seems better to just keep the JS version so there's less maintenance porting between two essentially identical implementations.

@nicolello-dev
Copy link

nicolello-dev commented Mar 19, 2024

All JavaScript is Typescript, but not the other way around. Seems better to just keep the JS version so there's less maintenance porting between two essentially identical implementations.

Since Typescript is compiled into Javascript, you would still only need to maintain one - the Typescript version.
Anyways, even if Typescript were a strict no-go, could we at least get some docstrings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants