Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL support using BSv5 #2002

Merged
merged 3 commits into from
May 16, 2024
Merged

Add RTL support using BSv5 #2002

merged 3 commits into from
May 16, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented May 16, 2024 •
edited

@chalin chalin marked this pull request as draft May 16, 2024 08:32
@chalin chalin mentioned this pull request May 16, 2024
Open
13 tasks
@chalin chalin changed the title RTL support Add RTL support using BSv5 May 16, 2024
@chalin chalin changed the title Add RTL support using BSv5 [TEMP UG CHANGE TO BE REMOVED] Add RTL support using BSv5 May 16, 2024
@sftim sftim mentioned this pull request May 16, 2024
Open
@chalin chalin changed the title [TEMP UG CHANGE TO BE REMOVED] Add RTL support using BSv5 Add RTL support using BSv5 May 16, 2024
@chalin chalin marked this pull request as ready for review May 16, 2024 22:47
@chalin
Copy link
Collaborator Author

chalin commented May 16, 2024

@google/docsy-approvers PTAL; I'll address any feedback in followup PRs, since there is more work to be done to fully support RTL.

@chalin chalin merged commit 3674691 into google:main May 16, 2024
11 checks passed
@chalin chalin deleted the chalin-im-rtl-2024-05-16 branch May 16, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RTL] Breadcrumb separator is in the wrong place
1 participant
@chalin