Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on bg-gradient-variant mixin #328

Merged
merged 1 commit into from Aug 19, 2020
Merged

Conversation

hube12
Copy link
Contributor

@hube12 hube12 commented Aug 18, 2020

Hi,
Since i updated my modules i sadly have this error that spam my console:

WARNING: The `bg-gradient-variant` mixin has been deprecated as of v4.5.0. It will be removed entirely in v5.
         on line 8:5 of themes/docsy/assets/vendor/bootstrap/scss/mixins/_deprecate.scss, in mixin `deprecate`
         from line 22:12 of themes/docsy/assets/vendor/bootstrap/scss/mixins/_background-variant.scss, in mixin `bg-gradient-variant`
         from line 37:18 of themes/docsy/assets/scss/_boxes.scss, in mixin `box-variant`
         from line 126:14 of themes/docsy/assets/scss/_boxes.scss
         from line 14:9 of stdin

Would it be possible to switch to the new format which is :
The official @mixin for bg-variant and bg-gradient-variant in bootstrap 4.5.0 is now @mixin bg-variant($parent, $color, $ignore-warning: false) and @mixin bg-gradient-variant($parent, $color, $ignore-warning: false).

Also in 5.0 bootstrap is moving away from it The bg-gradient-variant() mixin is removed since the .bg-gradient class can now be used to add gradients to elements instead of the .bg-gradient-* classes. see https://github.com/twbs/bootstrap/blob/main/site/content/docs/5.0/migration.md

related deprecated pr: twbs/bootstrap#30594

Fix #327

@google-cla
Copy link

google-cla bot commented Aug 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@hube12
Copy link
Contributor Author

hube12 commented Aug 18, 2020

@googlebot I signed it!

@LisaFC
Copy link
Collaborator

LisaFC commented Aug 19, 2020

Thanks, this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bg-gradient-variant mixin has been deprecated as of v4.5.0. It will be removed entirely in v5.
2 participants