Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Browsersync for Eleventy v2.x compatibility #182

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

pkvach
Copy link
Contributor

@pkvach pkvach commented Jan 6, 2024

A compatibility issue with Eleventy v2.x came up after a recent merge request "Bump axios and @11ty/eleventy #180". It updated Eleventy from 1.0.0 to 2.0.1
https://github.com/google/eleventy-high-performance-blog/actions/runs/6827178225/job/18568727206

In Eleventy v2 Eleventy Dev Server replaces Browsersync (11ty/eleventy#1305).

So I removed the Browsersync related code.
Eleventy Dev Server has built-in support for 404.html.
And there is no need for additional CSP code.

Copy link

google-cla bot commented Jan 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cramforce
Copy link
Collaborator

Is that gonna work with 11ty 1.0?

@pkvach
Copy link
Contributor Author

pkvach commented Jan 6, 2024

This won't work for Eleventy v1.0 because Eleventy Dev Server was added in v2.0
https://www.11ty.dev/blog/eleventy-v2/#plugins

@cramforce
Copy link
Collaborator

Should we update the package.json dependency on 11ty?

@pkvach
Copy link
Contributor Author

pkvach commented Jan 18, 2024

I noticed that the 11ty version has already been updated in the package.json file in pull request #180.
The update has already been merged, but the build failed:
https://github.com/google/eleventy-high-performance-blog/actions/runs/6827178225/job/18568727206

@cramforce
Copy link
Collaborator

OK, let's get this merged. I lost the ability to configure CI when I left Google, so stuff needs to be validated on a fork.

@cramforce cramforce merged commit e72d0c1 into google:main Jan 18, 2024
1 of 5 checks passed
@pkvach
Copy link
Contributor Author

pkvach commented Jan 18, 2024

Sure, I've already checked these changes. Thank you.

@pkvach pkvach deleted the fix-eleventy-two-compatibility branch January 18, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants