Skip to content

Commit

Permalink
Remove source compatibility with JDK 8
Browse files Browse the repository at this point in the history
remove JDK 8 from external CI, and add a use of a JDK 11 API
(Optional.isEmpty) to confirm.

#2730

PiperOrigin-RevId: 415040230
  • Loading branch information
cushon authored and Error Prone Team committed Dec 9, 2021
1 parent 758c1de commit 221a2ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest ]
java: [ 17, 11, 8 ]
java: [ 17, 11 ]
experimental: [ false ]
# Only test on macos and windows with a single recent JDK to avoid a
# combinatorial explosion of test configurations.
Expand Down Expand Up @@ -63,10 +63,10 @@ jobs:
steps:
- name: 'Check out repository'
uses: actions/checkout@v2
- name: 'Set up JDK 8'
- name: 'Set up JDK 11'
uses: actions/setup-java@v2
with:
java-version: 8
java-version: 11
distribution: 'zulu'
cache: 'maven'
server-id: ossrh
Expand Down
Expand Up @@ -147,7 +147,7 @@ private Description match(
ExpressionTree receiver,
VisitorState state) {
Optional<InlineMeData> inlineMe = InlineMeData.createFromSymbol(symbol);
if (!inlineMe.isPresent()) {
if (inlineMe.isEmpty()) {
return Description.NO_MATCH;
}

Expand Down

0 comments on commit 221a2ee

Please sign in to comment.