Improve repro for b/165671890

PiperOrigin-RevId: 423598508
google · Jan 23, 2022 · 882d7c9 · 882d7c9
1 parent d284923
commit 882d7c9
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/OrphanedFormatStringTest.java
@@ -104,15 +104,17 @@ public void formatMethod() {
         .doTest();
   }
 
+  // "$ f" is a valid format string, because ' ' is a flag
+  // TODO(b/165671890): consider adding a heuristic to skip these
   @Test
-  public void percent() {
+  public void spaceAfterPercent() {
     testHelper
         .addSourceLines(
             "Test.java",
             "class Test {",
             "  void f() {",
-            "    StringBuilder messageBuilder = ",
-            "        new StringBuilder(\"hakuna % matata\").append(\"y\").append(\"n\");",
+            "    // BUG: Diagnostic contains:",
+            "    StringBuilder messageBuilder = new StringBuilder(\"more than 50% finished\");",
             "  }",
             "}")
         .doTest();