Delete WrongParameterPackage

which was never productionized, and is buggy. Consistently using `@Override` seems to provide most of the value of this check, in terms of preventing accidentally overriding (or accidentally failing to override) a method. Fixes #1177 PiperOrigin-RevId: 350714077
google · Jan 8, 2021 · be57b1b · be57b1b
1 parent a5f3056
commit be57b1b
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 298 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/WrongParameterPackage.java b/core/src/main/java/com/google/errorprone/bugpatterns/WrongParameterPackage.java
diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java
@@ -365,7 +365,6 @@
 import com.google.errorprone.bugpatterns.WildcardImport;
 import com.google.errorprone.bugpatterns.WithSignatureDiscouraged;
 import com.google.errorprone.bugpatterns.WrongOneof;
-import com.google.errorprone.bugpatterns.WrongParameterPackage;
 import com.google.errorprone.bugpatterns.XorPower;
 import com.google.errorprone.bugpatterns.android.BinderIdentityRestoredDangerously;
 import com.google.errorprone.bugpatterns.android.BundleDeserializationCast;
@@ -1035,8 +1034,7 @@ public static ScannerSupplier errorChecks() {
           UrlInSee.class,
           UseEnumSwitch.class,
           VarChecker.class,
-          WildcardImport.class,
-          WrongParameterPackage.class
+          WildcardImport.class
           // end
           );
 

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/WrongParameterPackageTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/WrongParameterPackageTest.java
diff --git a/...t/java/com/google/errorprone/bugpatterns/testdata/WrongParameterPackageNegativeCases.java b/...t/java/com/google/errorprone/bugpatterns/testdata/WrongParameterPackageNegativeCases.java
diff --git a/...t/java/com/google/errorprone/bugpatterns/testdata/WrongParameterPackagePositiveCases.java b/...t/java/com/google/errorprone/bugpatterns/testdata/WrongParameterPackagePositiveCases.java
diff --git a/docs/bugpattern/ParameterPackage.md b/docs/bugpattern/ParameterPackage.md