Make a defensive null check in SameNameButDifferent.

Fixes(?) external #3245. (I haven't included a test as the external bug doesn't have a repro, and is apparently in generated code: which makes me assume something odd is going on.) PiperOrigin-RevId: 458755521
google · Jul 14, 2022 · dd6cb39 · dd6cb39
1 parent 49e4b34
commit dd6cb39
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/SameNameButDifferent.java b/core/src/main/java/com/google/errorprone/bugpatterns/SameNameButDifferent.java
@@ -183,6 +183,9 @@ private static Optional<Symbol> getBetterImport(TypeSymbol classSymbol, String s
     Symbol owner = classSymbol;
     long dots = simpleName.chars().filter(c -> c == '.').count();
     for (long i = 0; i < dots + 1; ++i) {
+      if (owner == null) {
+        return Optional.empty();
+      }
       owner = owner.owner;
     }
     if (owner instanceof ClassSymbol) {