Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ImmutableChecker switch expression test #3268

Closed
wants to merge 1 commit into from
Closed

Add ImmutableChecker switch expression test #3268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions core/src/test/java/com/google/errorprone/bugpatterns/threadsafety/ImmutableCheckerTest.java
View file
Open in desktop
Expand Up @@ -16,11 +16,14 @@

package com.google.errorprone.bugpatterns.threadsafety;

import static org.junit.Assume.assumeTrue;

import com.google.common.collect.ImmutableList;
import com.google.errorprone.CompilationTestHelper;
import com.google.errorprone.annotations.CanIgnoreReturnValue;
import com.google.errorprone.annotations.Immutable;
import com.google.errorprone.annotations.concurrent.LazyInit;
import com.google.errorprone.util.RuntimeVersion;
import java.util.Arrays;
import org.junit.Ignore;
import org.junit.Test;
Expand Down Expand Up @@ -2969,4 +2972,27 @@ public void anonymousClass_canCallSuperMethodOnNonImmutableSuperClass() {
"}")
.doTest();
}

@Test
public void switchExpressionsResultingInGenericTypes_doesNotThrow() {
assumeTrue(RuntimeVersion.isAtLeast14());
compilationHelper
.addSourceLines(
"Kind.java",
"import com.google.errorprone.annotations.Immutable;",
"@Immutable enum Kind { A, B; }")
.addSourceLines(
"Test.java",
"import java.util.Optional;",
"import java.util.function.Supplier;",
"class Test {",
" Supplier<Optional<String>> test(Kind kind) {",
" return switch (kind) {",
" case A -> Optional::empty;",
" case B -> () -> Optional.of(\"\");",
" };",
" }",
"}")
.doTest();
}
}