Make FlatState a Mapping instead of a dict #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgarciae (Done, as you requested.) |
NeilGirdhar
force-pushed
the
use_mapping
branch
3 times, most recently
from
fa0436e
to
6776c47
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3928 +/- ##
==========================================
- Coverage 60.43% 0.00% -60.44%
==========================================
Files 105 105
Lines 13263 13328 +65
==========================================
- Hits 8015 0 -8015
- Misses 5248 13328 +8080 ☔ View full report in Codecov by Sentry. |
cgarciae
approved these changes
May 22, 2024
|
@NeilGirdhar looks great! Thanks for doing this. |
|
Seems there are some git conflicts. |
|
Rebased to main. |
* Add nnx.traversals.{flatten_mapping, unflatten_dict}
* These are modified from traverse_util.{flatten_dict,
unflatten_dict}
* They are annotated so that any future changes to the function
(e.g., changing it back to work with dicts only) triggers a type
error.
* Minor tweaks to imports:
* import from collections.abc instead of typing since the latter
imports are deprecated.
* Import from flax.typing instead of flax.core.scope since the
latter has been moved.
* Add from __future__ import annotations so that the annotations
work on Python 3.9.
* Minor tweaks to code:
* Annotate some private functions to make them easier to understand.
* When printing a type, print its __qualname__ since that's a bit
easier to read (str instead of <class 'str'>).
Fixes google#3879
cgarciae
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nnx.traversals.{flatten_mapping, unflatten_dict}
Minor tweaks to imports:
__future__import annotations so that the annotations work on Python 3.9.Minor tweaks to code:
Fixes #3879