Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexboxLayoutManager child item margin is wrong when flex-direction is column #614

Open
1 task done
hjhjw1991 opened this issue Nov 4, 2022 · 0 comments
Open
1 task done

Comments

@hjhjw1991
Copy link

hjhjw1991 commented Nov 4, 2022

Issues and steps to reproduce

Please replace this with steps to reproduce your issue.
parent flex-direction: column
and
only the first child in recyclerview has topMargin.

Expected behavior

Please describe what you expected would happen.
layout should respect child margin correctly

Version of the flexbox library

3.0.0

Link to code

Please link to the code we can use to reproduce this issue.
A complete project we can build/run is preferred, if you can't provide one, please show
us relevant code

I have already figured out what went wrong. see my pull request

hjhjw1991 pushed a commit to hjhjw1991/flexbox-layout that referenced this issue Nov 4, 2022
hjhjw1991 pushed a commit to hjhjw1991/flexbox-layout that referenced this issue Nov 4, 2022
hjhjw1991 pushed a commit to hjhjw1991/flexbox-layout that referenced this issue Nov 4, 2022
hjhjw1991 added a commit to hjhjw1991/flexbox-layout that referenced this issue Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant