-
Notifications
You must be signed in to change notification settings - Fork 209
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Forcibly export fields for use by the reporter
The choice to avoid traversing unexported fields by default makes sense for the semantics of normal comparisons. However, the goal of the reporter is to prioritize humanly readable output. As such, it seems appropriate to forcibly export fields. This allows the String method to be called on such values.
- Loading branch information
Showing
2 changed files
with
9 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1776240
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\cc @cybrcodr. Sigh, I accidentally committed a change directly to master instead of branch for code review. Can you review this after the fact?
I miss Gerrit.
1776240
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. LGTM.