Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
actions: remove redundant gofmt and govet calls
gofmt and govet are not handled by golangci-lint, which runs in a separate actions workflow. No need to run them here as well.
- Loading branch information
1 parent
02c7be3
commit 139c9e7
Showing
1 changed file
with
3 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ jobs: | |
# is very little in the library that is platform specific | ||
- go-version: 1.x | ||
platform: windows-latest | ||
|
||
# only update test coverage stats with the most recent go version on linux | ||
- go-version: 1.x | ||
platform: ubuntu-latest | ||
|
@@ -38,13 +38,13 @@ jobs: | |
with: | ||
go-version: ${{ matrix.go-version }} | ||
- uses: actions/checkout@v2 | ||
|
||
# Get values for cache paths to be used in later steps | ||
- id: cache-paths | ||
run: | | ||
echo "::set-output name=go-cache::$(go env GOCACHE)" | ||
echo "::set-output name=go-mod-cache::$(go env GOMODCACHE)" | ||
- name: Cache go modules | ||
uses: actions/cache@v2 | ||
with: | ||
|
@@ -54,17 +54,10 @@ jobs: | |
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} | ||
restore-keys: ${{ runner.os }}-go- | ||
|
||
- name: Run go fmt | ||
if: runner.os != 'Windows' | ||
run: diff -u <(echo -n) <(gofmt -d -s .) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
willnorris
Author
Collaborator
|
||
|
||
- name: Ensure go generate produces a zero diff | ||
shell: bash | ||
run: go generate -x ./... && git diff --exit-code; code=$?; git checkout -- .; (exit $code) | ||
|
||
- name: Run go vet | ||
run: go vet ./... | ||
|
||
- name: Run go test | ||
run: go test -v -race -coverprofile coverage.txt -covermode atomic ./... | ||
|
||
|
@willnorris - I think we still need this, as no errors were flagged on this PR:
#2333
even though it obviously had
gofmt
problems.