Skip to content

Commit

Permalink
Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields w…
Browse files Browse the repository at this point in the history
…ith omitempty (#2289)

Fixes: #2286.
  • Loading branch information
leopoldwang committed Feb 14, 2022
1 parent 2be8000 commit 6964b1c
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 3 deletions.
8 changes: 8 additions & 0 deletions github/github-accessors.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions github/github-accessors_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions github/repos.go
Expand Up @@ -944,10 +944,10 @@ type PullRequestReviewsEnforcementUpdate struct {
DismissalRestrictionsRequest *DismissalRestrictionsRequest `json:"dismissal_restrictions,omitempty"`
// Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. Can be omitted.
DismissStaleReviews *bool `json:"dismiss_stale_reviews,omitempty"`
// RequireCodeOwnerReviews specifies if an approved review is required in pull requests including files with a designated code owner.
RequireCodeOwnerReviews bool `json:"require_code_owner_reviews,omitempty"`
// RequireCodeOwnerReviews specifies if merging pull requests is blocked until code owners have reviewed.
RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"`
// RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged.
// Valid values are 1 - 6.
// Valid values are 1 - 6 or 0 to not require reviewers.
RequiredApprovingReviewCount int `json:"required_approving_review_count"`
}

Expand Down

0 comments on commit 6964b1c

Please sign in to comment.