Change ProjectOptions (Public to Private) and Project struct fields (#…

…2111) Fixes: #2110
google · Dec 3, 2021 · b913905 · b913905
1 parent 392b7ea
commit b913905
Show file tree

Hide file tree

Showing 5 changed files with 82 additions and 42 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/github-stringify_test.go b/github/github-stringify_test.go
diff --git a/github/projects.go b/github/projects.go
@@ -18,18 +18,20 @@ type ProjectsService service
 
 // Project represents a GitHub Project.
 type Project struct {
-	ID         *int64     `json:"id,omitempty"`
-	URL        *string    `json:"url,omitempty"`
-	HTMLURL    *string    `json:"html_url,omitempty"`
-	ColumnsURL *string    `json:"columns_url,omitempty"`
-	OwnerURL   *string    `json:"owner_url,omitempty"`
-	Name       *string    `json:"name,omitempty"`
-	Body       *string    `json:"body,omitempty"`
-	Number     *int       `json:"number,omitempty"`
-	State      *string    `json:"state,omitempty"`
-	CreatedAt  *Timestamp `json:"created_at,omitempty"`
-	UpdatedAt  *Timestamp `json:"updated_at,omitempty"`
-	NodeID     *string    `json:"node_id,omitempty"`
+	ID                     *int64     `json:"id,omitempty"`
+	URL                    *string    `json:"url,omitempty"`
+	HTMLURL                *string    `json:"html_url,omitempty"`
+	ColumnsURL             *string    `json:"columns_url,omitempty"`
+	OwnerURL               *string    `json:"owner_url,omitempty"`
+	Name                   *string    `json:"name,omitempty"`
+	Body                   *string    `json:"body,omitempty"`
+	Number                 *int       `json:"number,omitempty"`
+	State                  *string    `json:"state,omitempty"`
+	CreatedAt              *Timestamp `json:"created_at,omitempty"`
+	UpdatedAt              *Timestamp `json:"updated_at,omitempty"`
+	NodeID                 *string    `json:"node_id,omitempty"`
+	OrganizationPermission *string    `json:"organization_permission,omitempty"`
+	Private                *bool      `json:"private,omitempty"`
 
 	// The User object that generated the project.
 	Creator *User `json:"creator,omitempty"`
@@ -83,7 +85,7 @@ type ProjectOptions struct {
 	// Sets visibility of the project within the organization.
 	// Setting visibility is only available
 	// for organization projects.(Optional.)
-	Public *bool `json:"public,omitempty"`
+	Private *bool `json:"private,omitempty"`
 }
 
 // UpdateProject updates a repository project.

diff --git a/github/projects_test.go b/github/projects_test.go
@@ -89,10 +89,10 @@ func TestProjectsService_UpdateProject(t *testing.T) {
 	defer teardown()
 
 	input := &ProjectOptions{
-		Name:   String("Project Name"),
-		Body:   String("Project body."),
-		State:  String("open"),
-		Public: Bool(true),
+		Name:    String("Project Name"),
+		Body:    String("Project body."),
+		State:   String("open"),
+		Private: Bool(false),
 
 		OrganizationPermission: String("read"),
 	}
@@ -857,15 +857,15 @@ func TestProjectOptions_Marshal(t *testing.T) {
 		Body:                   String("body"),
 		State:                  String("state"),
 		OrganizationPermission: String("op"),
-		Public:                 Bool(true),
+		Private:                Bool(false),
 	}
 
 	want := `{
 		"name": "name",
 		"body": "body",
 		"state": "state",
 		"organization_permission": "op",
-		"public": true
+		"private": false
 	}`
 
 	testJSONMarshal(t, u, want)