Revert "Fix: Remove Sort & Direction Fields From IssueListCommentsOpt…

…ions" (#1857)
google · Apr 24, 2021 · cceb4d4 · cceb4d4
1 parent b235769
commit cceb4d4
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 2 deletions.
diff --git a/github/github-accessors.go b/github/github-accessors.go
diff --git a/github/github-accessors_test.go b/github/github-accessors_test.go
diff --git a/github/issues_comments.go b/github/issues_comments.go
@@ -35,6 +35,12 @@ func (i IssueComment) String() string {
 // IssueListCommentsOptions specifies the optional parameters to the
 // IssuesService.ListComments method.
 type IssueListCommentsOptions struct {
+	// Sort specifies how to sort comments. Possible values are: created, updated.
+	Sort *string `url:"sort,omitempty"`
+
+	// Direction in which to sort comments. Possible values are: asc, desc.
+	Direction *string `url:"direction,omitempty"`
+
 	// Since filters comments by time.
 	Since *time.Time `url:"since,omitempty"`
 

diff --git a/github/issues_comments_test.go b/github/issues_comments_test.go
@@ -23,14 +23,18 @@ func TestIssuesService_ListComments_allIssues(t *testing.T) {
 		testMethod(t, r, "GET")
 		testHeader(t, r, "Accept", mediaTypeReactionsPreview)
 		testFormValues(t, r, values{
-			"since": "2002-02-10T15:30:00Z",
-			"page":  "2",
+			"sort":      "updated",
+			"direction": "desc",
+			"since":     "2002-02-10T15:30:00Z",
+			"page":      "2",
 		})
 		fmt.Fprint(w, `[{"id":1}]`)
 	})
 
 	since := time.Date(2002, time.February, 10, 15, 30, 0, 0, time.UTC)
 	opt := &IssueListCommentsOptions{
+		Sort:        String("updated"),
+		Direction:   String("desc"),
 		Since:       &since,
 		ListOptions: ListOptions{Page: 2},
 	}