Add list options support for environments #2258
Conversation
This commit updates existing tests for ListEnvironments to ensure that they will be compatible with the EnvironmentListOptions implementation.
This commit implements EnvironmentListOptions for the ListEnvironments method by adding a new parameter and using the addOptions function. Additionally I've created a new struct called EnvironmentListOptions and embedded ListOptions with the idea that this could be expanded one day.
This commit adds an example to show how to work with ListEnvironments and it's new opts parameter.
gmlewis
added
the
Breaking API Change
Codecov Report
@@ Coverage Diff @@
## master #2258 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 114 114
Lines 10266 10269 +3
=======================================
+ Hits 10042 10045 +3
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
Made some minor change to this example that include removing os.Exit(), fixing some unnecessary variable declarations and godoc improvements.
|
@gmlewis All of your comments should now be resolved. Thanks for taking the time to review. |
"unnecessary leading newline (whitespace)"
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
|
Hello! Is there anything else you would like me to change for this PR? |
No, thank you. We are awaiting any other contributor to this repo to give an LGTM and approve this PR before merging. |
|
Hey hey! Hope everything is going well! Wondering if we could request a review from another contributor 🙏? Appreciate everyone is super busy though. |
|
Thank you 🙏 😄 |
|
Than you, @Parker77 ! |
|
import "github.com/google/go-github/v43/github" |
Closes #2257
This PR introduces an EnvironmentListOptions parameter for the ListEnvironments method.
Tests have also been updated to reflect the changes and an example has been added to the example directory.