Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list options support for environments #2258

Merged
merged 6 commits into from Feb 3, 2022
Merged

Add list options support for environments #2258

merged 6 commits into from Feb 3, 2022

Commits on Jan 17, 2022

  1. Tests for EnvironmentListOptions 

    This commit updates existing tests for ListEnvironments to ensure that
they will be compatible with the EnvironmentListOptions implementation.
    @chelnak
    chelnak committed Jan 17, 2022
    Copy the full SHA
    b07ef07 View commit details
    Browse the repository at this point in the history

  2. EnvironmentListOptions implementation 

    This commit implements EnvironmentListOptions for the ListEnvironments
method by adding a new parameter and using the addOptions function.

Additionally I've created a new struct called EnvironmentListOptions
and embedded ListOptions with the idea that this could be expanded
one day.
    @chelnak
    chelnak committed Jan 17, 2022
    Copy the full SHA
    bda70c0 View commit details
    Browse the repository at this point in the history

  3. ListEnvironments example 

    This commit adds an example to show how to work with ListEnvironments
and it's new opts parameter.
    @chelnak
    chelnak committed Jan 17, 2022
    Copy the full SHA
    32b107b View commit details
    Browse the repository at this point in the history

  4. Address PR comments 

    Made some minor change to this example that include removing os.Exit(),
fixing some unnecessary variable declarations and godoc improvements.
    @chelnak
    chelnak committed Jan 17, 2022
    Copy the full SHA
    d92496f View commit details
    Browse the repository at this point in the history

  5. Resolved a golangci-lint issue 

    "unnecessary leading newline (whitespace)"
    @chelnak
    chelnak committed Jan 17, 2022
    Copy the full SHA
    316ee55 View commit details
    Browse the repository at this point in the history

  6. Update example/listenvironments/main.go 

    Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
    @chelnak @gmlewis
    chelnak and gmlewis committed Jan 17, 2022
    Copy the full SHA
    ee239cd View commit details
    Browse the repository at this point in the history