Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add security-advisory and code-scanning-alert event types #2311

Merged
merged 5 commits into from Mar 4, 2022

Conversation

sourikghosh
Copy link
Contributor

Signed-off-by: Sourik Ghosh sourikghosh31@gmail.com

fixes #2306

What does this PR do ?
security-advisory event type with unit test added
code-scanning-alert event type with unit test added

… added

Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh
Copy link
Contributor Author

ping reviewer
@gmlewis

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #2311 (3b9f271) into master (2a15bc2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2311   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         115      115           
  Lines       10403    10415   +12     
=======================================
+ Hits        10179    10191   +12     
  Misses        156      156           
  Partials       68       68           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <ø> (ø)
github/event_types.go 100.00% <ø> (ø)
github/repos_hooks_deliveries.go 92.45% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a15bc2...3b9f271. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sourikghosh !
Just a few minor changes, please, then we will need a second LGTM from any other contributor to this repo before merging.

github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh sourikghosh requested a review from gmlewis March 3, 2022 15:34
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, @sourikghosh !
Just a couple minor tweaks, please, then we should be ready for another LGTM and merging.

github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
github/event_types.go Outdated Show resolved Hide resolved
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
@sourikghosh sourikghosh requested a review from gmlewis March 3, 2022 17:47
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sourikghosh !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@sourikghosh
Copy link
Contributor Author

could any of you please review this PR
@Parker77 @JordanSussman @raynigon @contributors

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to have the link to the github docs in the comment.
Besides that, LGTM

github/event_types.go Show resolved Hide resolved
Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 4, 2022

Thank you, @raynigon !
Merging after tests pass.

@gmlewis gmlewis changed the title security-advisory and code-scanning-alert event types with unit test added Add security-advisory and code-scanning-alert event types Mar 4, 2022
@gmlewis gmlewis merged commit 4d609bd into google:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add security_advisory and code_scanning_alert event types
3 participants