Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query parameter visible_to_repository in ListOrganizationRunnerGroups #2329

Merged
merged 5 commits into from May 16, 2022
Merged

Support query parameter visible_to_repository in ListOrganizationRunnerGroups #2329

merged 5 commits into from May 16, 2022

Conversation

TingluoHuang
Copy link
Contributor

@TingluoHuang TingluoHuang commented Apr 8, 2022 •
edited

Fixing #2328

Support visible_to_repository query parameter in ListOrganizationRunnerGroups.

@google-cla
Copy link

google-cla bot commented Apr 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@TingluoHuang TingluoHuang marked this pull request as ready for review April 9, 2022 01:12
@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited

Codecov Report

Merging #2329 (049ab48) into master (1df4afd) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2329   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         118      118           
  Lines       10458    10458           
=======================================
  Hits        10254    10254           
  Misses        140      140           
  Partials       64       64
Impacted Files Coverage Δ
github/actions_runner_groups.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df4afd...049ab48. Read the comment docs.

gmlewis
gmlewis requested changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @TingluoHuang !

github/actions_runner_groups.go Outdated Show resolved Hide resolved
github/actions_runner_groups.go Outdated Show resolved Hide resolved
github/actions_runner_groups.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Apr 11, 2022
TingluoHuang and others added 3 commits April 11, 2022 10:48
@TingluoHuang @gmlewis
Update github/actions_runner_groups.go
618f797 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@TingluoHuang @gmlewis
Update github/actions_runner_groups.go
43920fa 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@TingluoHuang
feedback.
049ab48
gmlewis
gmlewis approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @TingluoHuang !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 11, 2022
@toast-gear toast-gear mentioned this pull request May 11, 2022
Closed
raynigon
raynigon approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label May 16, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented May 16, 2022

LGTM

Thank you, @raynigon !
Merging.

@gmlewis gmlewis merged commit 78c231a into google:master May 16, 2022
@gmlewis gmlewis mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@raynigon raynigon raynigon approved these changes

Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TingluoHuang @gmlewis @raynigon