-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alphanumeric param to AutolinkOptions #2450
Add alphanumeric param to AutolinkOptions #2450
Conversation
The authorizations_test already checks for these env vars when needed
Codecov Report
@@ Coverage Diff @@
## master #2450 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10690 10690
=======================================
Hits 10480 10480
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @douglascayers !
Looks great to me.
Awaiting second LGTM from any other contributor to this repo before merging.
Hi @alexal, as a contributor to the autolinks feature, I'd appreciate your review of my proposed changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you, @raynigon ! |
Summary
Resolves #2449
Changes
IsAlphanumeric
param toAutolinkOptions
andAutolink
structs ofgithub/repos_autolinks.go
createRandomTestRepository
function intest/integration/github_test.go
to look up the owner to create the repo under if a name isn't specified explicitly. ChecksGITHUB_OWNER
env var else falls back to user the oauth token belongs to.init
function oftest/integration/github_test.go
because those checks already occur in thetest/integration/authorizations_test.go
file as needed. This made it easier for me to run integrations tests without setting env vars that weren't needed.Tests
github/repos_autolinks_test.go
test/integration/repos_test.go
Created an alphanumeric autolink
Created a numeric autolink