Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org struct fields #2471

Merged
merged 2 commits into from Sep 18, 2022
Merged

Add org struct fields #2471

merged 2 commits into from Sep 18, 2022

Conversation

kuhlman-labs
Copy link
Contributor

The update an organization API has additional configurable fields that the Organization struct does not support:

WebCommitSignoffRequired
AdvancedSecurityEnabledForNewRepos
DependabotAlertsEnabledForNewRepos
DependabotSecurityUpdatesEnabledForNewRepos
DependencyGraphEnabledForNewRepos
SecretScanningEnabledForNewRepos
SecretScanningPushProtectionEnabledForNewRepos

Proposing adding these fields to enable them to be configurable with Organization.Edit

@google-cla
Copy link

google-cla bot commented Sep 18, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #2471 (9b0e7fc) into master (30d1431) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2471   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         122      122           
  Lines       10695    10695           
=======================================
  Hits        10485    10485           
  Misses        144      144           
  Partials       66       66           
Impacted Files Coverage Δ
github/orgs.go 96.90% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kuhlman-labs !
LGTM.
Merging.

@gmlewis gmlewis changed the title Feature/adding org struct fields closes#2470 Add org struct fields Sep 18, 2022
@gmlewis gmlewis merged commit 642c343 into google:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants