Adding resource github_organization_settings to provider closes#1125 #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcampbell
approved these changes
Sep 21, 2022
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "read", | ||
| ValidateFunc: validation.StringInSlice([]string{"read", "write", "admin", "none"}, false), |
There was a problem hiding this comment.
If we find ourselves duplicating this logic in the future, we may abstract this into its own helper somewhere.
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "advanced_security_enabled_for_new_repositories": { |
There was a problem hiding this comment.
Nice work making changes to the upstream library and following through with them here!
| ) | ||
|
|
||
| func TestAccGithubOrganizationSettings(t *testing.T) { | ||
| t.Run("creates organization settings without error", func(t *testing.T) { |
There was a problem hiding this comment.
Tests are passing for me locally!
This was referenced Sep 21, 2022
kazaker
pushed a commit
to auto1-oss/terraform-provider-github
that referenced
this pull request
Dec 28, 2022
…ntegrations#1298) * adding resouce github_settings to provider * Spacing and comment changes Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ntegrations#1298) * adding resouce github_settings to provider * Spacing and comment changes Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource allows us to create and manage organization settings using this API endpoint:
https://docs.github.com/en/rest/orgs/orgs#update-an-organization
Also included here are a dependency bump for to go-github vendor. This was necessary for this resource to work as the updated version has the additional Org Struct fields needed.
google/go-github#2471
Additionally some minor edits to the resource
github_tag_protectiondoc and error message.closes:
#1125