Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for security manager endpoints #2530

Merged
merged 4 commits into from Nov 1, 2022

Conversation

jeremyhayes
Copy link
Contributor

Fixes #2529

@google-cla
Copy link

google-cla bot commented Oct 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Add support to List/Add/Remove security manager teams for an
organization.
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeremyhayes !
Just a few minor tweaks please.

github/orgs_security_managers.go Outdated Show resolved Hide resolved
github/orgs_security_managers.go Outdated Show resolved Hide resolved
github/orgs_security_managers.go Outdated Show resolved Hide resolved
github/orgs_security_managers_test.go Outdated Show resolved Hide resolved
github/orgs_security_managers_test.go Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2530 (8f99c89) into master (dfd7737) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2530   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      124    +1     
  Lines       10813    10840   +27     
=======================================
+ Hits        10594    10621   +27     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/orgs_security_managers.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeremyhayes jeremyhayes marked this pull request as ready for review October 26, 2022 01:26
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jeremyhayes !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 1, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 1, 2022

Thank you, @valbeat and @raynigon !
Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for organization security managers
4 participants