Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dependabot alert endpoints #2554

Merged
merged 6 commits into from Nov 7, 2022

Conversation

francois2metz
Copy link
Contributor

@francois2metz francois2metz commented Nov 1, 2022

This add support for reading dependabot alerts: https://docs.github.com/en/rest/dependabot/alerts

I added the First and Last parameters to the ListCursorOptions. It seems to replace the PerPage parameter.

@google-cla
Copy link

google-cla bot commented Nov 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @francois2metz !

github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/dependabot_alerts.go Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
github/github.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2022

@francois2metz - just FYI - no need to force-push to your PRs in this repo because we always squash-merge at the end anyway, and it is easier for reviewers if you don't. See CONTRIBUTING.md for more details. Also, please make sure to run gofmt on the modified files and go generate ./... before pushing. Thanks.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @francois2metz !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2022

@francois2metz - please make sure to run gofmt and go generate ./... and push the results to make the tests pass.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #2554 (83796ef) into master (66a053a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2554      +/-   ##
==========================================
+ Coverage   97.97%   97.98%   +0.01%     
==========================================
  Files         123      125       +2     
  Lines       10813    10873      +60     
==========================================
+ Hits        10594    10654      +60     
  Misses        150      150              
  Partials       69       69              
Impacted Files Coverage Δ
github/github.go 97.37% <ø> (ø)
github/dependabot_alerts.go 100.00% <100.00%> (ø)
github/orgs_security_managers.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 7, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 7, 2022

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 3b3cbf1 into google:master Nov 7, 2022
@francois2metz francois2metz deleted the dependabot-alerts branch December 1, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants