Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tables github_repository_dependabot_alert and github_organization_dependabot_alert #215

Merged
merged 3 commits into from Dec 27, 2022
Merged

Add tables github_repository_dependabot_alert and github_organization_dependabot_alert #215

merged 3 commits into from Dec 27, 2022

Conversation

francois2metz
Copy link
Contributor

@francois2metz francois2metz commented Nov 5, 2022 •
edited

Example query results

Results 
Add example SQL query results here (please include the input queries as well)

@francois2metz francois2metz changed the title Add table github_dependabot_alert Add tables github_repository_dependabot_alert and github_organization_dependabot_alert Dec 1, 2022
@francois2metz francois2metz force-pushed the dependabot branch 2 times, most recently from cc97108 to 8a4f04c Compare December 5, 2022 21:30
@francois2metz francois2metz marked this pull request as ready for review December 5, 2022 21:31
@francois2metz
Copy link
Contributor Author

Hi @misraved. I finished the first version of the two tables. Would love to have some feedbacks.

@misraved
Copy link
Contributor

misraved commented Dec 6, 2022

Great to hear that @francois2metz 👍. Let me take a take a stab at this and see if everything checks out 👍.

misraved
misraved reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francois2metz for adding the new tables 👍.

The structure and examples look fantastic, I have left a few minor changes, please let me know if you have questions.

docs/tables/github_organization_dependabot_alert.md Outdated Show resolved Hide resolved
docs/tables/github_repository_dependabot_alert.md Outdated Show resolved Hide resolved
github/table_github_organization_dependabot_alert.go Outdated Show resolved Hide resolved
@francois2metz
Copy link
Contributor Author

I updated the PR to fix the issues.

cbruno10
cbruno10 requested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francois2metz Please see review comments, if you have any questions, let us know!

github/table_github_organization_dependabot_alert.go Outdated Show resolved Hide resolved
github/table_github_organization_dependabot_alert.go Outdated Show resolved Hide resolved
github/table_github_organization_dependabot_alert.go Outdated Show resolved Hide resolved
docs/tables/github_organization_dependabot_alert.md Outdated Show resolved Hide resolved
docs/tables/github_repository_dependabot_alert.md Outdated Show resolved Hide resolved
@cbruno10
Copy link
Contributor

@francois2metz Thanks for making the updates so quickly! I've added one more suggestion in #215 (comment), otherwise the tables look great to me. Please let me know if you have any other thoughts on that particular column or questions on it.

Thanks!

@misraved misraved merged commit a93495a into turbot:main Dec 27, 2022
@francois2metz francois2metz deleted the dependabot branch December 27, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbruno10 cbruno10 cbruno10 requested changes

@misraved misraved misraved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@francois2metz @misraved @cbruno10