Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OIDC subject claim customization templates for actions #2615

Merged
merged 3 commits into from Jan 5, 2023
Merged

Support OIDC subject claim customization templates for actions #2615

merged 3 commits into from Jan 5, 2023

Conversation

F21
Copy link
Contributor

@F21 F21 commented Jan 3, 2023

Closes #2614

@F21 F21 mentioned this pull request Jan 3, 2023
Closed
1 task
gmlewis
gmlewis requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @F21 !
Just a few tweaks and questions, please.

github/actions_oidc.go Outdated Show resolved Hide resolved
github/actions_oidc.go Outdated Show resolved Hide resolved
github/actions_oidc.go Outdated Show resolved Hide resolved
github/actions_oidc.go Outdated Show resolved Hide resolved
github/actions_oidc.go Outdated Show resolved Hide resolved
github/actions_oidc.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 4, 2023 •
edited

Codecov Report

Merging #2615 (0d02761) into master (c5583e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2615   +/-   ##
=======================================
  Coverage   97.99%   98.00%           
=======================================
  Files         127      128    +1     
  Lines       10948    10977   +29     
=======================================
+ Hits        10729    10758   +29     
  Misses        150      150           
  Partials       69       69
Impacted Files Coverage Δ
github/actions_oidc.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 4, 2023
gmlewis
gmlewis approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @F21 !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@F21
Copy link
Contributor Author

F21 commented Jan 4, 2023

Thanks so much for the quick review, @gmlewis !

valbeat
valbeat approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 5, 2023

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 93166f4 into google:master Jan 5, 2023
@F21 F21 deleted the actions-oidc branch January 5, 2023 21:15
@F21 F21 mentioned this pull request Jan 9, 2023
Merged
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting customization template for OIDC subject claims in GitHub Actions
3 participants
@F21 @gmlewis @valbeat