-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove blob_href from check annotations #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mcristina422.
Travis-CI is complaining that there is a test failing. I looked into it, and it appears that there is one more blob_href
references here:
https://github.com/google/go-github/blob/master/github/checks_test.go#L597
that needs to be removed.
After that is fixed, it LGTM and then we can merge after getting a second LGTM.
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 86 86
Lines 6040 6040
=======================================
Hits 4435 4435
Misses 836 836
Partials 769 769
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mcristina422!
LGTM.
Awaiting second LGTM before merging.
Note to self: this is a breaking API change and will require a major version bump.
Thank you, @gauntface! |
@gmlewis yeah, I think you're right. But that just means the next time a new version is tagged it should bump the major version. It doesn't necessarily mean we need to tag this right away. |
Oh, OK. Do you have a preference, @willnorris ? I've been attempting to release&tag after each PR just in case we need to refer to a specific version (so that we don't have to use a commit or PR as our reference), but I can reduce the frequency if you prefer. I'll go ahead and continue catching up with the outstanding PRs while I've been without internet, and then make a new release and tag, and that should hopefully reduce the noise. |
Ah! I see you opened #1280 for discussion. Excellent. We can continue there. |
BREAKING
As defined on https://developer.github.com/v3/checks/runs/#annotations-object
blob_href
is no longer a parameter.Opening this as discussed in #1241 (review)