Add Base, Ref, and SHA to EditChange struct

[JacobValdemar]

Add support for webhook which is triggered when you change the base branch in a pull request after opening it.

Fixes: #1617

[gmlewis]

Thank you, @JacobValdemar .

Please add a unit test that exercises the marshal/unmarshal of this struct.

[codecov]

Codecov Report

Merging #1619 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1619   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files          97       97           
  Lines        8855     8855           
=======================================
  Hits         6027     6027           
  Misses       1912     1912           
  Partials      916      916           

Impacted Files	Coverage Δ
github/event_types.go	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57a3a8...db89fcb. Read the comment docs.

[JacobValdemar]

Good idea about the unit test @gmlewis. I can't locate where the other content in event_types.go are tested. Do you have any immediate position on where this test should be placed? 🙂

[gmlewis]

I can't locate where the other content in event_types.go are tested. Do you have any immediate position on where this test should be placed?

Oh, wow! You are right... I thought we had that.

How about creating a new file, event_types_test.go with the appropriate header, and then take a look at #55 to see a large number of examples of PRs dedicated to just testing the marshaling and unmarshaling of the structs? That would be fantastic.

Thank you, @JacobValdemar !

[JacobValdemar]

Hi again @gmlewis :) I've now added the unit tests you requested.

[gmlewis]

Thank you, @JacobValdemar !
LGTM.

Awaiting second LGTM before merging.

[wesleimp]

Thank you, @JacobValdemar
LGTM 👌🏼

[gmlewis]

Thank you, @wesleimp !
Merging.

[jhlegarreta]

I'm wondering whether there is an estimated time of arrival of the feature in this PR to be shipped into a release. If I'm not wrong release v33.0.0 did not include it.

Some downstream repositories (cross-referencing srvaroa/labeler#13) would benefit from having it on a release. Thanks.

[gmlewis]

Hi @jhlegarreta - as of #1280, all releases (major, minor, and patch) are now on-demand. (I should probably put this in the README.md... sorry.)

I won't be able to start the process quite yet, but I believe we could cut a new release later today (or early tomorrow) if I can get some assistance with code reviews.

[jhlegarreta]

@gmlewis thanks for the prompt answer. Wow, it's nice that you are able to cut releases on demand. I appreciate the effort.

[gmlewis]

Hi @jhlegarreta - https://github.com/google/go-github/releases/tag/v34.0.0 has been released.

[jhlegarreta]

Much appreciated @gmlewis ! Thanks.

If I am allowed to post here a question tangentially related to this PR (let me know if I should ask it elsewhere), I'd like to know whether the package supports pull_request_target webhook events. This PR was cross-referenced from srvaroa/labeler#13 concerning that aspect, but having read the current code (e.g. see the webhook event files here, the message mapping and the PR series of structs) I have not found support for the webhook.

Am I right or is the webhook supported using some other mechanism or path that I do not see?

Would it be possible to add it as time permits? A few prominent open source projects from Apache or the ITK ecosystem could possibly benefit from it.

Thanks.

[gmlewis]

Ah, yes, it looks like our repo doesn't support it yet. I'll open an issue and invite volunteers to implement it. Thanks, @jhlegarreta .

[gmlewis]

There is now a new issue to support it: #1834.