Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty #2289

Merged
merged 4 commits into from Feb 14, 2022
Merged

Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty #2289

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb1fed7
Update repos.go
leopoldwang Feb 11, 2022
92f17af
regenerated required code
leopoldwang Feb 12, 2022
7a5d2da
updated comments to match github rest api doc
leopoldwang Feb 12, 2022
d11e2fd
Update github/repos.go
leopoldwang Feb 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion github/repos.go
View file
Open in desktop
Expand Up @@ -945,7 +945,7 @@ type PullRequestReviewsEnforcementUpdate struct {
// Specifies if approved reviews can be dismissed automatically, when a new commit is pushed. Can be omitted.
DismissStaleReviews *bool `json:"dismiss_stale_reviews,omitempty"`
// RequireCodeOwnerReviews specifies if an approved review is required in pull requests including files with a designated code owner.
RequireCodeOwnerReviews bool `json:"require_code_owner_reviews,omitempty"`
RequireCodeOwnerReviews *bool `json:"require_code_owner_reviews,omitempty"`
// RequiredApprovingReviewCount specifies the number of approvals required before the pull request can be merged.
// Valid values are 1 - 6.
leopoldwang marked this conversation as resolved.
Show resolved Hide resolved
RequiredApprovingReviewCount int `json:"required_approving_review_count"`
leopoldwang marked this conversation as resolved.
Show resolved Hide resolved
Expand Down