Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples dir into its own Go module #2310

Merged
merged 1 commit into from Mar 8, 2022

Commits on Mar 2, 2022

  1. Move examples into its own Go module

    We notices that go-github has an example that references ghinstallation,
    which causes a circular module dependency. While this is technically
    fine (https://go.dev/ref/mod#minimal-version-selection should resolve
    it), there's probably not a strong reason to pull in ghinstallation and
    other example dependencies not needed by the core github package unless
    it is strictly needed.
    
    This just breaks the example folder into its own module so that users
    can import the core go-github package with the minimal set of
    dependencies. This should not affect any functionality.
    I tried to keep versions the roughly same for compatibility, though
    replaced the go-github dependency with the parent to try and keep
    examples up-to-date with HEAD (this could possibly be replaced with
    https://go.dev/ref/mod#workspaces later).
    wlynch committed Mar 2, 2022
    Copy the full SHA
    0c53a68 View commit details
    Browse the repository at this point in the history