Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to list custom roles for organizations #2336

Merged
merged 4 commits into from Apr 26, 2022

Conversation

tamboliasir1
Copy link
Contributor

@tamboliasir1 tamboliasir1 commented Apr 18, 2022

Fixes: #2327 .

Thanks for this opportunity.

@gmlewis gmlewis changed the title Added support to list custom roles for organizations Add support to list custom roles for organizations Apr 18, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tamboliasir1 !
Let's please change some of the naming and update the comments.

github/org_custom_roles.go Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles_test.go Show resolved Hide resolved
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 18, 2022

Please also make sure to run go generate ./... and push (not force-push) the results as described in our CONTRIBUTING.md document.

@tamboliasir1
Copy link
Contributor Author

Hi @gmlewis I have made changes and pushed commit. Can you please review? Thank you so much.

github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #2336 (b01926c) into master (00e4233) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2336   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         118      119    +1     
  Lines       10458    10471   +13     
=======================================
+ Hits        10254    10267   +13     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/org_custom_roles.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e4233...b01926c. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was wrong.
After you fix the URL in the comments, LGTM.
We will then be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Show resolved Hide resolved
Copy link

@reedloden reedloden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typos. :-)

github/github-accessors.go Outdated Show resolved Hide resolved
github/github-accessors_test.go Outdated Show resolved Hide resolved
github/github-accessors_test.go Outdated Show resolved Hide resolved
github/github-accessors_test.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles.go Outdated Show resolved Hide resolved
github/org_custom_roles_test.go Outdated Show resolved Hide resolved
@tamboliasir1
Copy link
Contributor Author

HI @reedloden @gmlewis Sorry for this silly typo I have resolved it please review. Please let me know if there is anything. Thank you.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tamboliasir1 !
And thank you, @reedloden for catching the typos!
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

Copy link
Contributor

@joshua-hancox joshua-hancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Not a previous contributor though, just an interested party 😄 )

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 26, 2022

LGTM (Not a previous contributor though, just an interested party 😄 )

Thank you, @joshuahancox !

Merging.

@gmlewis gmlewis merged commit 448e04d into google:master Apr 26, 2022
@tamboliasir1
Copy link
Contributor Author

Thank you @gmlewis. Would love to contribute more!!😄

@reedloden
Copy link

@gmlewis can we get a release of go-github that includes this feature?

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 28, 2022

@gmlewis can we get a release of go-github that includes this feature?

I will work on getting a release out before Saturday.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 30, 2022

@gmlewis can we get a release of go-github that includes this feature?

@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR.

@reedloden
Copy link

@gmlewis can we get a release of go-github that includes this feature?

@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR.

@gmlewis woot woot. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a way to list custom roles for organizations
4 participants