Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit with obvious gofmt issue #2348

Closed
wants to merge 1 commit into from

Conversation

willnorris
Copy link
Collaborator

No description provided.

@willnorris
Copy link
Collaborator Author

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #2348 (2941973) into master (ca149ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2348   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         119      119           
  Lines       10471    10471           
=======================================
  Hits        10267    10267           
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/github.go 97.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca149ad...2941973. Read the comment docs.

@willnorris
Copy link
Collaborator Author

This looks to be a problem with golangci-lint, or how we're using it. Running it manually at commit 51df464 (the last in #2333 before the gofmt fix) passes when it shouldn't. I'll keep digging.

@willnorris
Copy link
Collaborator Author

Ah, I think I found it.... it's because the example directory is its own go module. I don't think golangci-lint will descent into other modules. cd'ing into the examples directory and then running golangci-lint there correctly identifies the issue. So we'll need to change our actions workflow to manually run on examples and scrape and any other separate modules we have. Gotta run for now, but I can take a look at that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant