Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GetCodeownersErrors to RepositoriesService (#2405) #2408

Merged
merged 6 commits into from Jul 16, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
56 changes: 56 additions & 0 deletions github/github-accessors.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

70 changes: 70 additions & 0 deletions github/github-accessors_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 41 additions & 0 deletions github/repos_codeowners.go
@@ -0,0 +1,41 @@
package github
cbrgm marked this conversation as resolved.
Show resolved Hide resolved

import (
"context"
"fmt"
)

// CodeownersErrors represents a list of syntax errors detected in the CODEOWNERS file.
type CodeownersErrors struct {
Errors []*CodeownersError `json:"errors"`
}

// CodeownersError represents a syntax error detected in the CODEOWNERS file.
type CodeownersError struct {
cbrgm marked this conversation as resolved.
Show resolved Hide resolved
Line *int `json:"line"`
Column *int `json:"column"`
Kind *string `json:"kind"`
Source *string `json:"source"`
Suggestion *string `json:"suggestion"`
cbrgm marked this conversation as resolved.
Show resolved Hide resolved
Message *string `json:"message"`
Path *string `json:"path"`
}

// GetCodeownersErrors lists any syntax errors that are detected in the CODEOWNERS file.
//
// GitHub API docs: https://docs.github.com/en/rest/repos/repos#list-codeowners-errors
func (s *RepositoriesService) GetCodeownersErrors(ctx context.Context, owner, repo string) (*CodeownersErrors, *Response, error) {
u := fmt.Sprintf("repos/%v/%v/codeowners/errors", owner, repo)
req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
return nil, nil, err
}

codeownersErrors := &CodeownersErrors{}
resp, err := s.client.Do(ctx, req, codeownersErrors)
if err != nil {
return nil, resp, err
}

return codeownersErrors, resp, nil
}
105 changes: 105 additions & 0 deletions github/repos_codeowners_test.go
@@ -0,0 +1,105 @@
package github
cbrgm marked this conversation as resolved.
Show resolved Hide resolved

import (
"context"
"fmt"
"net/http"
"testing"

"github.com/google/go-cmp/cmp"
)

func TestRepositoriesService_GetCodeownersErrors(t *testing.T) {
client, mux, _, teardown := setup()
defer teardown()

mux.HandleFunc("/repos/o/r/codeowners/errors", func(w http.ResponseWriter, r *http.Request) {
testMethod(t, r, "GET")
testHeader(t, r, "Accept", mediaTypeV3)
fmt.Fprint(w, `{
"errors": [
{
"line": 1,
"column": 1,
"kind": "Invalid pattern",
"source": "***/*.rb @monalisa",
"suggestion": "Did you mean **/*.rb?",
"message": "Invalid pattern on line 3: Did you mean **/*.rb?\n\n ***/*.rb @monalisa\n ^",
"path": ".github/CODEOWNERS"
}
]
}
`)
})

ctx := context.Background()
codeownersErrors, _, err := client.Repositories.GetCodeownersErrors(ctx, "o", "r")
if err != nil {
t.Errorf("Repositories.GetCodeownersErrors returned error: %v", err)
}

want := &CodeownersErrors{
Errors: []*CodeownersError{
{
Line: Int(1),
Column: Int(1),
Kind: String("Invalid pattern"),
Source: String("***/*.rb @monalisa"),
Suggestion: String("Did you mean **/*.rb?"),
Message: String("Invalid pattern on line 3: Did you mean **/*.rb?\n\n ***/*.rb @monalisa\n ^"),
Path: String(".github/CODEOWNERS"),
},
},
}
if !cmp.Equal(codeownersErrors, want) {
t.Errorf("Repositories.GetCodeownersErrors returned %+v, want %+v", codeownersErrors, want)
}

const methodName = "GetCodeownersErrors"
testBadOptions(t, methodName, func() (err error) {
_, _, err = client.Repositories.GetCodeownersErrors(ctx, "\n", "\n")
return err
})

testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.Repositories.GetCodeownersErrors(ctx, "o", "r")
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
return resp, err
})
}

func TestCodeownersErrors_Marshal(t *testing.T) {
testJSONMarshal(t, &CodeownersErrors{}, "{}")

u := &CodeownersErrors{
Errors: []*CodeownersError{
{
Line: Int(1),
Column: Int(1),
Kind: String("Invalid pattern"),
Source: String("***/*.rb @monalisa"),
Suggestion: String("Did you mean **/*.rb?"),
Message: String("Invalid pattern on line 3: Did you mean **/*.rb?\n\n ***/*.rb @monalisa\n ^"),
Path: String(".github/CODEOWNERS"),
},
},
}

want := `{
"errors": [
{
"line": 1,
"column": 1,
"kind": "Invalid pattern",
"source": "***/*.rb @monalisa",
"suggestion": "Did you mean **/*.rb?",
"message": "Invalid pattern on line 3: Did you mean **/*.rb?\n\n ***/*.rb @monalisa\n ^",
"path": ".github/CODEOWNERS"
}
]
}
`
testJSONMarshal(t, u, want)
}