Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for JSON marshaling #2540

Closed
wants to merge 1 commit into from

Conversation

rahulkarmore
Copy link
Contributor

Hi creator,
Added test cases for JSON Resources :
ExternalGroup
Helps: #55

I have followed all the guidelines to contribute to this repository.
Please revert in case of any changes are needed.
I am a first-time contributor to Hackoctober, It will be a great help if u can encourage me & accept my contribution.

@google-cla
Copy link

google-cla bot commented Oct 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title Add test case for JSON ExternalGroup marshaling - teams_test.go Add test case for JSON marshaling Oct 28, 2022
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rahulkarmore !
LGTM.
Merging.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 28, 2022

Whups, I need to wait for the CLA to be signed and resolved before I can merge this PR.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2540 (2f10a9a) into master (f550bc8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2540   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rahulkarmore
Copy link
Contributor Author

Close this merge request, New merge request will be
#2541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants