Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for merge queue ruleset JSON unmarshaling #3131

Merged
merged 5 commits into from Apr 19, 2024

Conversation

Matthew-Reidy
Copy link
Contributor

@Matthew-Reidy Matthew-Reidy commented Apr 18, 2024

Fixes: #3098.

Added support for respository ruleset merge_queue in JSON unmarshalling code with accompanying tests

Copy link

google-cla bot commented Apr 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title added support for merge queue ruleset JSON unmarshalling Add support for merge queue ruleset JSON unmarshaling Apr 18, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
Just a couple minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

AUTHORS Outdated Show resolved Hide resolved
github/repos_rules.go Outdated Show resolved Hide resolved
github/repos_rules.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (db98743).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   97.72%   92.88%   -4.84%     
==========================================
  Files         153      170      +17     
  Lines       13390    11426    -1964     
==========================================
- Hits        13085    10613    -2472     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Matthew-Reidy
Copy link
Contributor Author

Matthew-Reidy commented Apr 18, 2024

Sure thing. I'll fix those items shortly

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Matthew-Reidy !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Apr 18, 2024
github/repos_rules.go Outdated Show resolved Hide resolved
@liaodaniel
Copy link
Contributor

Just a minor comment to update but looks good otherwise

Co-authored-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
@Matthew-Reidy
Copy link
Contributor Author

changes to that comment have been made

Copy link
Contributor

@liaodaniel liaodaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 19, 2024

Thank you, @liaodaniel !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Apr 19, 2024
@gmlewis gmlewis merged commit b02f283 into google:master Apr 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Queues break repository ruleset unmarshaling
3 participants