Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Changes Field to Member Event Type. #3153

Merged
merged 1 commit into from Apr 25, 2024

Conversation

tayosec
Copy link
Contributor

@tayosec tayosec commented Apr 25, 2024

Fixes: #3154.

The member webhook event as described by github documentation contains a changes object. https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#member

However, the struct that defines the Member webhook event type is missing the changes object . This PR adds the missing changes object to the MemberEvent type.

The `member` webhook event as described by github documentation contains a `changes` object.
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=edited#member

This PR adds the missing `changes` object to the `MemberEvent` type.
Copy link

google-cla bot commented Apr 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (2b8c7fa) to head (c190d6b).
Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
- Coverage   97.72%   92.88%   -4.84%     
==========================================
  Files         153      170      +17     
  Lines       13390    11426    -1964     
==========================================
- Hits        13085    10613    -2472     
- Misses        215      723     +508     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tayosec !
LGTM.
Merging.

@gmlewis gmlewis merged commit d067824 into google:master Apr 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook MemberEvent Type is Missing Changes Object
2 participants