New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow an empty array of repo ids as a request parameter #3155
Conversation
Co-authored-by: Daniel Liao <10663736+liaodaniel@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3155 +/- ##
==========================================
- Coverage 97.72% 92.89% -4.84%
==========================================
Files 153 170 +17
Lines 13390 11436 -1954
==========================================
- Hits 13085 10623 -2462
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Matthew-Reidy !
One tiny nit so we have complete sentences in our godocs, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Matthew-Reidy !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Thank you, @be0x74a ! |
Fixes: #3106.
Add extra endpoint function that allows client to pass an empty array of repository ids to the installations/<install_id>/access_tokens endpoint as a parameter. Response lists all repositories in an installation.