Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonArray now can return the List of JsonElement #1209

Closed
wants to merge 2 commits into from
Closed

JsonArray now can return the List of JsonElement #1209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffb988a
JsonArray now can return the List of JsonElement
ayarullin Dec 19, 2017
8663b91
fixes in accordance to pr comments
ayarullin Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions gson/src/main/java/com/google/gson/JsonArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,15 @@ public boolean getAsBoolean() {
throw new IllegalStateException();
}

/**
* Returns this array as List of JsonElement
*
* @return this array as List of JsonElement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant doc.

*/
public List<JsonElement> getAsList() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about asList()?

return elements;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return Collections.unmodifiableList(new ArrayList<>(elements));

Copy link
Author

@ayarullin ayarullin Dec 20, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... Why? The idea of this metod is modify JsonArray by modifying List (for example for sorting).

That said, it seems like an asList does belong here, since this already implements Iterable.

We cannot convert Iterable to List without going over all elements. This is not optimal way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i misunderstood the use case.

}

@Override
public boolean equals(Object o) {
return (o == this) || (o instanceof JsonArray && ((JsonArray) o).elements.equals(elements));
Expand Down