Add Gson method for creating new instances (using InstanceCreators)
#1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Sep 17, 2021
Comment on lines
+1022
to
+1023
| // TODO: Specify thrown exception type; but ConstructorConstructor currently uses | ||
| // RuntimeException instead of specific exception |
There was a problem hiding this comment.
Not sure if this can be resolved in a reasonable way yet.
Ideally in the future Gson's exception hierarchy should be refactored. There are exception types missing, such as for this case or when serialization fails (Gson's exceptions all seem to be related to deserialization), which currently leads to usage of RuntimeException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the method
Gson.createInstance(TypeToken)exposingConstructorConstructor's functionality.This allows custom TypeAdapterFactories to easily create new instances which can be useful for example for custom collection-like types or for custom reflection based adapters which want to support
@JsonAdapter, see #1794 (comment).Might resolve or relate to #537, though from its description it is not completely clear what that issue was proposing and the attached patch does not seem to be available anymore.