Mark some tests that don't pass under Android as @AndroidIncompatible.

PiperOrigin-RevId: 444869256
google · Apr 27, 2022 · 98c0a78 · 98c0a78
1 parent a24a894
commit 98c0a78
Show file tree

Hide file tree

Showing 20 changed files with 42 additions and 14 deletions.
diff --git a/android/guava-testlib/test/com/google/common/testing/GcFinalizationTest.java b/android/guava-testlib/test/com/google/common/testing/GcFinalizationTest.java
@@ -32,6 +32,7 @@
  * @author Martin Buchholz
  * @author mike nonemacher
  */
+@AndroidIncompatible // depends on details of gc
 
 public class GcFinalizationTest extends TestCase {
 

diff --git a/android/guava-tests/test/com/google/common/base/AbstractIteratorTest.java b/android/guava-tests/test/com/google/common/base/AbstractIteratorTest.java
@@ -173,6 +173,7 @@ public Integer computeNext() {
 
 
   @GwtIncompatible // weak references
+  @AndroidIncompatible // depends on details of GC
   public void testFreesNextReference() {
     Iterator<Object> itr =
         new AbstractIterator<Object>() {

diff --git a/android/guava-tests/test/com/google/common/base/EnumsTest.java b/android/guava-tests/test/com/google/common/base/EnumsTest.java
@@ -81,6 +81,7 @@ public void testGetIfPresent_whenNoMatchingConstant() {
 
 
   @GwtIncompatible // weak references
+  @AndroidIncompatible // depends on details of GC and classloading
   public void testGetIfPresent_doesNotPreventClassUnloading() throws Exception {
     WeakReference<?> shadowLoaderReference = doTestClassUnloading();
     GcFinalization.awaitClear(shadowLoaderReference);

diff --git a/android/guava-tests/test/com/google/common/base/FinalizableReferenceQueueTest.java b/android/guava-tests/test/com/google/common/base/FinalizableReferenceQueueTest.java
@@ -31,6 +31,10 @@
  *
  * @author Bob Lee
  */
+// - depends on details of GC and classloading
+// - .class files aren't available
+// - possibly no real concept of separate ClassLoaders?
+@AndroidIncompatible
 public class FinalizableReferenceQueueTest extends TestCase {
 
   private FinalizableReferenceQueue frq;
@@ -101,7 +105,6 @@ public void finalizeReferent() {
         };
   }
 
-  @AndroidIncompatible // no concept of separate ClassLoaders
   public void testDecoupledLoader() {
     FinalizableReferenceQueue.DecoupledLoader decoupledLoader =
         new FinalizableReferenceQueue.DecoupledLoader() {
@@ -141,7 +144,6 @@ protected synchronized Class<?> loadClass(String name, boolean resolve)
     }
   }
 
-  @AndroidIncompatible // TODO(cpovirk): How significant is this failure?
   public void testGetFinalizerUrl() {
     assertNotNull(getClass().getResource("internal/Finalizer.class"));
   }

diff --git a/android/guava-tests/test/com/google/common/io/ByteStreamsTest.java b/android/guava-tests/test/com/google/common/io/ByteStreamsTest.java
@@ -51,6 +51,7 @@ public void testCopyChannel() throws IOException {
     assertThat(out.toByteArray()).isEqualTo(expected);
   }
 
+  @AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 
   public void testCopyFileChannel() throws IOException {
     final int chunkSize = 14407; // Random prime, unlikely to match any internal chunk size

diff --git a/android/guava-tests/test/com/google/common/io/FileBackedOutputStreamTest.java b/android/guava-tests/test/com/google/common/io/FileBackedOutputStreamTest.java
@@ -28,6 +28,7 @@
  *
  * @author Chris Nokleberg
  */
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FileBackedOutputStreamTest extends IoTestCase {
 
 

diff --git a/android/guava-tests/test/com/google/common/io/FilesFileTraverserTest.java b/android/guava-tests/test/com/google/common/io/FilesFileTraverserTest.java
@@ -34,6 +34,7 @@
  * @author Jens Nyman
  */
 
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FilesFileTraverserTest extends TestCase {
 
   private File rootDir;

diff --git a/android/guava-tests/test/com/google/common/io/FilesTest.java b/android/guava-tests/test/com/google/common/io/FilesTest.java
@@ -47,6 +47,7 @@
  * @author Chris Nokleberg
  */
 
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FilesTest extends IoTestCase {
 
   public static TestSuite suite() {

diff --git a/android/guava-tests/test/com/google/common/io/ResourcesTest.java b/android/guava-tests/test/com/google/common/io/ResourcesTest.java
@@ -22,9 +22,7 @@
 import com.google.common.base.Charsets;
 import com.google.common.collect.ImmutableList;
 import com.google.common.testing.NullPointerTester;
-import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
-import java.io.DataInputStream;
 import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
@@ -42,6 +40,7 @@
 
 public class ResourcesTest extends IoTestCase {
 
+  @AndroidIncompatible // wouldn't run anyway, but strip the source entirely because of b/230620681
   public static TestSuite suite() {
     TestSuite suite = new TestSuite();
     suite.addTest(
@@ -62,9 +61,9 @@ public void testToString() throws IOException {
     assertThat(Resources.toString(resource, Charsets.US_ASCII)).isNotEqualTo(I18N);
   }
 
-  public void testToToByteArray() throws IOException {
-    byte[] data = Resources.toByteArray(classfile(Resources.class));
-    assertEquals(0xCAFEBABE, new DataInputStream(new ByteArrayInputStream(data)).readInt());
+  public void testToByteArray() throws IOException {
+    URL resource = getClass().getResource("testdata/i18n.txt");
+    assertThat(Resources.toByteArray(resource)).isEqualTo(I18N.getBytes(Charsets.UTF_8));
   }
 
   public void testReadLines() throws IOException {
@@ -134,6 +133,7 @@ public void testGetResource_relativePath() {
     assertNotNull(Resources.getResource(getClass(), "testdata/i18n.txt"));
   }
 
+  @AndroidIncompatible // Android prevents most access to files
   public void testGetResource_contextClassLoader() throws IOException {
     // Check that we can find a resource if it is visible to the context class
     // loader, even if it is not visible to the loader of the Resources class.
@@ -181,6 +181,7 @@ public void testGetResource_contextClassLoaderNull() {
     }
   }
 
+  @AndroidIncompatible // .class files aren't available
   public void testNulls() {
     new NullPointerTester()
         .setDefault(URL.class, classfile(ResourcesTest.class))

diff --git a/android/guava-tests/test/com/google/common/reflect/ClassPathTest.java b/android/guava-tests/test/com/google/common/reflect/ClassPathTest.java
@@ -178,6 +178,7 @@ public void testJarFileWithSpaces() throws Exception {
     assertThat(ClassPath.from(classloader).getTopLevelClasses()).isNotEmpty();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScan_classPathCycle() throws IOException {
     File jarFile = File.createTempFile("with_circular_class_path", ".jar");
@@ -201,6 +202,7 @@ public void testScanFromFile_fileNotExists() throws IOException {
         .isEmpty();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScanFromFile_notJarFile() throws IOException {
     ClassLoader classLoader = ClassPathTest.class.getClassLoader();
@@ -399,6 +401,7 @@ public void testNulls() throws IOException {
         .testAllPublicInstanceMethods(ClassPath.from(getClass().getClassLoader()));
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testLocationsFrom_idempotentScan() throws IOException {
     ImmutableSet<ClassPath.LocationInfo> locations =
@@ -429,6 +432,7 @@ public void testLocationEquals() {
         .testEquals();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScanAllResources() throws IOException {
     assertThat(scanResourceNames(ClassLoader.getSystemClassLoader()))

diff --git a/guava-testlib/test/com/google/common/testing/GcFinalizationTest.java b/guava-testlib/test/com/google/common/testing/GcFinalizationTest.java
@@ -32,6 +32,7 @@
  * @author Martin Buchholz
  * @author mike nonemacher
  */
+@AndroidIncompatible // depends on details of gc
 
 public class GcFinalizationTest extends TestCase {
 

diff --git a/guava-tests/test/com/google/common/base/AbstractIteratorTest.java b/guava-tests/test/com/google/common/base/AbstractIteratorTest.java
@@ -173,6 +173,7 @@ public Integer computeNext() {
 
 
   @GwtIncompatible // weak references
+  @AndroidIncompatible // depends on details of GC
   public void testFreesNextReference() {
     Iterator<Object> itr =
         new AbstractIterator<Object>() {

diff --git a/guava-tests/test/com/google/common/base/EnumsTest.java b/guava-tests/test/com/google/common/base/EnumsTest.java
@@ -81,6 +81,7 @@ public void testGetIfPresent_whenNoMatchingConstant() {
 
 
   @GwtIncompatible // weak references
+  @AndroidIncompatible // depends on details of GC and classloading
   public void testGetIfPresent_doesNotPreventClassUnloading() throws Exception {
     WeakReference<?> shadowLoaderReference = doTestClassUnloading();
     GcFinalization.awaitClear(shadowLoaderReference);

diff --git a/guava-tests/test/com/google/common/base/FinalizableReferenceQueueTest.java b/guava-tests/test/com/google/common/base/FinalizableReferenceQueueTest.java
@@ -31,6 +31,10 @@
  *
  * @author Bob Lee
  */
+// - depends on details of GC and classloading
+// - .class files aren't available
+// - possibly no real concept of separate ClassLoaders?
+@AndroidIncompatible
 public class FinalizableReferenceQueueTest extends TestCase {
 
   private FinalizableReferenceQueue frq;
@@ -102,7 +106,6 @@ public void finalizeReferent() {
         };
   }
 
-  @AndroidIncompatible // no concept of separate ClassLoaders
   public void testDecoupledLoader() {
     FinalizableReferenceQueue.DecoupledLoader decoupledLoader =
         new FinalizableReferenceQueue.DecoupledLoader() {
@@ -142,7 +145,6 @@ protected synchronized Class<?> loadClass(String name, boolean resolve)
     }
   }
 
-  @AndroidIncompatible // TODO(cpovirk): How significant is this failure?
   public void testGetFinalizerUrl() {
     assertNotNull(getClass().getResource("internal/Finalizer.class"));
   }

diff --git a/guava-tests/test/com/google/common/io/ByteStreamsTest.java b/guava-tests/test/com/google/common/io/ByteStreamsTest.java
@@ -51,6 +51,7 @@ public void testCopyChannel() throws IOException {
     assertThat(out.toByteArray()).isEqualTo(expected);
   }
 
+  @AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 
   public void testCopyFileChannel() throws IOException {
     final int chunkSize = 14407; // Random prime, unlikely to match any internal chunk size

diff --git a/guava-tests/test/com/google/common/io/FileBackedOutputStreamTest.java b/guava-tests/test/com/google/common/io/FileBackedOutputStreamTest.java
@@ -28,6 +28,7 @@
  *
  * @author Chris Nokleberg
  */
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FileBackedOutputStreamTest extends IoTestCase {
 
 

diff --git a/guava-tests/test/com/google/common/io/FilesFileTraverserTest.java b/guava-tests/test/com/google/common/io/FilesFileTraverserTest.java
@@ -34,6 +34,7 @@
  * @author Jens Nyman
  */
 
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FilesFileTraverserTest extends TestCase {
 
   private File rootDir;

diff --git a/guava-tests/test/com/google/common/io/FilesTest.java b/guava-tests/test/com/google/common/io/FilesTest.java
@@ -47,6 +47,7 @@
  * @author Chris Nokleberg
  */
 
+@AndroidIncompatible // Android forbids much filesystem access. Maybe we could make it work?
 public class FilesTest extends IoTestCase {
 
   public static TestSuite suite() {

diff --git a/guava-tests/test/com/google/common/io/ResourcesTest.java b/guava-tests/test/com/google/common/io/ResourcesTest.java
@@ -22,9 +22,7 @@
 import com.google.common.base.Charsets;
 import com.google.common.collect.ImmutableList;
 import com.google.common.testing.NullPointerTester;
-import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
-import java.io.DataInputStream;
 import java.io.File;
 import java.io.IOException;
 import java.io.PrintWriter;
@@ -42,6 +40,7 @@
 
 public class ResourcesTest extends IoTestCase {
 
+  @AndroidIncompatible // wouldn't run anyway, but strip the source entirely because of b/230620681
   public static TestSuite suite() {
     TestSuite suite = new TestSuite();
     suite.addTest(
@@ -62,9 +61,9 @@ public void testToString() throws IOException {
     assertThat(Resources.toString(resource, Charsets.US_ASCII)).isNotEqualTo(I18N);
   }
 
-  public void testToToByteArray() throws IOException {
-    byte[] data = Resources.toByteArray(classfile(Resources.class));
-    assertEquals(0xCAFEBABE, new DataInputStream(new ByteArrayInputStream(data)).readInt());
+  public void testToByteArray() throws IOException {
+    URL resource = getClass().getResource("testdata/i18n.txt");
+    assertThat(Resources.toByteArray(resource)).isEqualTo(I18N.getBytes(Charsets.UTF_8));
   }
 
   public void testReadLines() throws IOException {
@@ -134,6 +133,7 @@ public void testGetResource_relativePath() {
     assertNotNull(Resources.getResource(getClass(), "testdata/i18n.txt"));
   }
 
+  @AndroidIncompatible // Android prevents most access to files
   public void testGetResource_contextClassLoader() throws IOException {
     // Check that we can find a resource if it is visible to the context class
     // loader, even if it is not visible to the loader of the Resources class.
@@ -181,6 +181,7 @@ public void testGetResource_contextClassLoaderNull() {
     }
   }
 
+  @AndroidIncompatible // .class files aren't available
   public void testNulls() {
     new NullPointerTester()
         .setDefault(URL.class, classfile(ResourcesTest.class))

diff --git a/guava-tests/test/com/google/common/reflect/ClassPathTest.java b/guava-tests/test/com/google/common/reflect/ClassPathTest.java
@@ -184,6 +184,7 @@ public void testJarFileWithSpaces() throws Exception {
     assertThat(ClassPath.from(classloader).getTopLevelClasses()).isNotEmpty();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScan_classPathCycle() throws IOException {
     File jarFile = File.createTempFile("with_circular_class_path", ".jar");
@@ -260,6 +261,7 @@ public void testScanFromFile_fileNotExists() throws IOException {
         .isEmpty();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScanFromFile_notJarFile() throws IOException {
     ClassLoader classLoader = ClassPathTest.class.getClassLoader();
@@ -458,6 +460,7 @@ public void testNulls() throws IOException {
         .testAllPublicInstanceMethods(ClassPath.from(getClass().getClassLoader()));
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testLocationsFrom_idempotentScan() throws IOException {
     ImmutableSet<ClassPath.LocationInfo> locations =
@@ -488,6 +491,7 @@ public void testLocationEquals() {
         .testEquals();
   }
 
+  @AndroidIncompatible // ClassPath is documented as not supporting Android
 
   public void testScanAllResources() throws IOException {
     assertThat(scanResourceNames(ClassLoader.getSystemClassLoader()))