Avoid reflection on java.util.concurrent internals during tests.
#6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Under modern JDKs, it will fail. This lets us remove one of our `--add-opens` lines. (I haven't looked into [the others](#5801 (comment)).) Example failure: ``` java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Thread java.util.concurrent.locks.AbstractOwnableSynchronizer.getExclusiveOwnerThread() accessible: module java.base does not "opens java.util.concurrent.locks" to unnamed module @5ba184fc; did you mean --add-opens=java.base/java.util.concurrent.locks=ALL-UNNAMED at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:348) at java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:280) at java.lang.reflect.Method.checkCanSetAccessible(Method.java:198) at java.lang.reflect.Method.setAccessible(Method.java:192) at com.google.common.util.concurrent.InterruptibleTaskTest.testInterruptIsSlow(InterruptibleTaskTest.java:160) ``` Relevant to #5801 RELNOTES=n/a PiperOrigin-RevId: 469500716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reflection on
java.util.concurrentinternals during tests.Under modern JDKs, it will fail.
This lets us remove one of our
--add-openslines. (I haven't looked into the others.)Example failure:
Relevant to #5801
RELNOTES=n/a